[webkit-reviews] review denied: [Bug 20176] querySelectorAll id optimization no longer working : [Attachment 22488] Patch; Passes run-webkit-tests and doesn't regress http://ejohn.org/apps/selectortest/#target

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied 's request for review:
Bug 20176: querySelectorAll id optimization no longer working
https://bugs.webkit.org/show_bug.cgi?id=20176

Attachment 22488: Patch; Passes run-webkit-tests and doesn't regress
http://ejohn.org/apps/selectortest/#target
https://bugs.webkit.org/attachment.cgi?id=22488&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
The check shouldn't be necessary, and can be made an ASSERT as far as I can
tell.  It should also read querySelector->m_attr== idAttr, not
querySelector->m_attr.localName() == idAttr.

I believe this will also break some uses of querySelector("#camalCase"); in
quirks mode.  We probably need to disable the optimization in quirks mode
methinks.