[webkit-reviews] review requested: [Bug 19975] [OpenBSD] Patches to enable build of WebKit : [Attachment 22335] patch against svn

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 17 04:59:29 PDT 2008

Landry Breuil <landry at fr.homeunix.org> has asked  for review:
Bug 19975: [OpenBSD] Patches to enable build of WebKit

Attachment 22335: patch against svn

------- Additional Comments from Landry Breuil <landry at fr.homeunix.org>
And here's a cleaner, simpler patchset against svn, works fine with midori &
ChangeLogs entries are included.
- i finally added a temporary signbit/isfinite implemetation in MathExtras.h,
similar to what is done for Solaris. Once we'll have them in libm it shouldn't
- finally, Thread.h patching is not necessary, we have to link with
libstdc++-4.2 anyway (that'll be our only local patch against GNUMakefile.am,
because on openbsd libstdc++ in /usr/lib is 3.3 version, libstdc++ 4.2 is
installed in /usr/local/lib/libestdc++)
- a non-intrusive patch for WebKitTools/DumpRenderTree/DumpRenderTree.h has
been added to conditionally declare the method. I think there's a better way to
handle it, but it compiles and runs fine this way. Having a HAVE_WCHAR
detection could help maybe.
- while here i kept the PLATFORM(SPARC64) definition, needed for the upcoming
fix for alignment problem on sparc64.

I hope this patchset is correct, and am just waiting for a new nightly build
including it to import my port of webkit & midori in OpenBSD's ports-tree. The
fix for sparc64 will be worked on afterwards.

More information about the webkit-reviews mailing list