[webkit-reviews] review cancelled: [Bug 19813] [GTK] WebKit crashes on invalid settings notify callback : [Attachment 21996] Disconnect notify callback on finalize

[bugzilla-daemon at webkit.org]

Christian Dywan <christian at imendio.com> has cancelled 's request for review:
Bug 19813: [GTK] WebKit crashes on invalid settings notify callback
https://bugs.webkit.org/show_bug.cgi?id=19813

Attachment 21996: Disconnect notify callback on finalize
https://bugs.webkit.org/attachment.cgi?id=21996&action=edit

------- Additional Comments from Christian Dywan <christian at imendio.com>
(In reply to comment #4)
> (From update of attachment 21996 [edit])
> Looks sensible.
> 
> I only wonder about the (gpointer) G_CALLBACK() mix in regard to handling
this
> callback in the various methods but I have not checked if I we get compile
> warnings when always using G_CALLBACK...

We can't use G_CALLBACK() when disconnecting the handler, since that
unfortunately breaks with the compiler saying that it can't cast »void (*)()«
to »void*«.

Committed in revision 35219.