[webkit-reviews] review denied: [Bug 19965] @mediaall recognized as @media all rather than as a generic (unrecognized ATKEYWORD) : [Attachment 22253] Fixed tabbing and added expected.txt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 16 01:37:52 PDT 2008


Rob Buis <rwlbuis at gmail.com> has denied Jacob Refstrup
<jacob.refstrup at hp.com>'s request for review:
Bug 19965: @mediaall recognized as @media all rather than as a generic
(unrecognized ATKEYWORD)
https://bugs.webkit.org/show_bug.cgi?id=19965

Attachment 22253: Fixed tabbing and added expected.txt 
https://bugs.webkit.org/attachment.cgi?id=22253&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
'ealier' is mentioned in the ChangeLog. Email address needs to be set.

You need to rerun the layout ChangeLog so it lists the .txt file too.

Does the patch cause no regressions on the tests?

If you can fix the minor niggles, put up the new patch and have assured there
are no regressions with the patch, then I'll okay it.


More information about the webkit-reviews mailing list