[webkit-reviews] review denied: [Bug 20029] [XBL] Add more tags : [Attachment 22262] Add <binding>, <template>, <div> and <content> stubs

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 20029: [XBL] Add more tags
https://bugs.webkit.org/show_bug.cgi?id=20029

Attachment 22262: Add <binding>, <template>, <div> and <content> stubs
https://bugs.webkit.org/attachment.cgi?id=22262&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
As Hyatt says, any element which does not require custom behavior does not need
to be generated for the factory (But should be generated as part of the
XBLNames file).  You might have to add code to the generation scripts for that
(But html needs that code anyway... when we finally make HTMLNames and
HTMLElementFactory autogen -- there is another bug on that).

If it doesn't need custom behavior, you just test for the element using:

element->hasTagName(XBLNames::divTag)

the generated factory stuff should correctly generate generic XBLElements in
that case, since these elements will have the XBL namespace (I know this works
for SVG, so I'm sure the generated stuff will do the right hting for XBL too.)