[webkit-reviews] review granted: [Bug 17589] Scroll wheel sensitivity ignored : [Attachment 22284] Corrected patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 15 13:21:50 PDT 2008

Eric Seidel <eric at webkit.org> has granted Maxime Britto <britto at apple.com>'s
request for review:
Bug 17589: Scroll wheel sensitivity ignored

Attachment 22284: Corrected patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks great!

I suggest you make:
if (deltaX)

part of the 
scrollAndAcceptEvent inline
as an early return:

if (!delta)

Also, there are some spacing issues here:

+static inline void adjustDeltaForPageScrollMode(float& delta, bool
pageScrollEnabled, int visibleWidthOrHeight)
+    if (pageScrollEnabled)
+	     delta = (delta > 0 ? visibleWidthOrHeight : -visibleWidthOrHeight)

Land away!

More information about the webkit-reviews mailing list