[webkit-reviews] review requested: [Bug 17906] white-space: pre-wrap or -webkit-line-break: after-white-space text can overlap float at end of line : [Attachment 22285] Fix for floats added in trailing whitespace for an already full linebox

[bugzilla-daemon at webkit.org]

Jacob Refstrup <jacob.refstrup at hp.com> has asked  for review:
Bug 17906: white-space: pre-wrap or -webkit-line-break: after-white-space text
can overlap float at end of line
https://bugs.webkit.org/show_bug.cgi?id=17906

Attachment 22285: Fix for floats added in trailing whitespace for an already
full linebox
https://bugs.webkit.org/attachment.cgi?id=22285&action=edit

------- Additional Comments from Jacob Refstrup <jacob.refstrup at hp.com>
The root cause seems to be that the call to skipWhitespace(InlineIterator&)
when the line box is already full causes floats to be added (correct) but also
positioned (incorrect); the positioning should be deferred until newLine() is
called.

I've regressed this on gtk without issues (but then again gtk doesn't seem to
dump render trees) but will need a volunteer to check it on MacOSX.