[webkit-reviews] review requested: [Bug 18464] incorrect translation of wxMouse event to webkit mouse event : [Attachment 22136] Patch to use wxMouseEvent::LeftIsDown and related functions

[bugzilla-daemon at webkit.org]

Kevin Watters <kevinwatters at gmail.com> has asked  for review:
Bug 18464: incorrect translation of wxMouse event  to webkit mouse event
https://bugs.webkit.org/show_bug.cgi?id=18464

Attachment 22136: Patch to use wxMouseEvent::LeftIsDown and related functions
https://bugs.webkit.org/attachment.cgi?id=22136&action=edit

------- Additional Comments from Kevin Watters <kevinwatters at gmail.com>
With the above changes, text selection isn't working on MSW. WebKit is
expecting m_button to reflect a currently depressed button as well as if a
button is changing state--so wxMouseEvent::Button isn't enough, since it only
shows button changes.

The attached patch includes calls to wxMouseEvent::LeftIsDown() and sibling
functions to check the current button state.