[webkit-reviews] review denied: [Bug 19911] :read-only and :read-write pseudoclasses support : [Attachment 22107] Support for :read-only and :read-write pseudoclasses

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 7 10:02:35 PDT 2008

Adele Peterson <adele at apple.com> has denied Michelangelo De Simone
<m.des at mac.com>'s request for review:
Bug 19911: :read-only and :read-write pseudoclasses support

Attachment 22107: Support for :read-only and :read-write pseudoclasses

------- Additional Comments from Adele Peterson <adele at apple.com>
Looks pretty good- I have just a few comments:

atomic strings in CSSSelector.cpp should be readOnly and readWrite

you shouldn't need the check  && !e->isInputTypeHidden()

you've left out checks for search fields and isindex - instead of using the
specific checks for the type, you can use isTextField().

More information about the webkit-reviews mailing list