[webkit-reviews] review requested: [Bug 19822] REGRESSION (r30243): setting location.hash to "#" causes a reload : [Attachment 22031] Revised proposed patch

[bugzilla-daemon at webkit.org]

Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 19822: REGRESSION (r30243): setting location.hash to "#" causes a reload
https://bugs.webkit.org/show_bug.cgi?id=19822

Attachment 22031: Revised proposed patch
https://bugs.webkit.org/attachment.cgi?id=22031&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
Here is a new patch incorporating the comments posted in this bug.

Here is the output when the test fails:

main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
main frame - willPerformClientRedirectToURL:
http://127.0.0.1:8000/loading/location-hash-reload-cycle.html 
main frame - didCancelClientRedirectForFrame
main frame - willPerformClientRedirectToURL:
http://127.0.0.1:8000/loading/location-hash-reload-cycle.html 
main frame - didHandleOnloadEventsForFrame
main frame - willPerformClientRedirectToURL:
http://127.0.0.1:8000/loading/location-hash-reload-cycle.html 
main frame - didFinishDocumentLoadForFrame
main frame - didFinishLoadForFrame
This test checks that no loader actions occur when setting window.location.hash
to the empty string or "#". If this test fails when run in a browser, it will
reload continuously. If this test fails when run in DumpRenderTree, the
FrameLoader callback output will contain willPerformClientRedirectToURL
callbacks.

Both of the window.location.hashes change the output independently of each
other. When run in a browser, it is very noticeable that it is reloading
forever.