[webkit-reviews] review denied: [Bug 19041] [wx] Frames support : [Attachment 21119] first pass at PltformScrollbar

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 1 08:30:48 PDT 2008


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Robin Dunn
<robin at alldunn.com>'s request for review:
Bug 19041: [wx] Frames support
https://bugs.webkit.org/show_bug.cgi?id=19041

Attachment 21119: first pass at PltformScrollbar
https://bugs.webkit.org/attachment.cgi?id=21119&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Thanks for the patch, Robin!

r- since this patch needs ChangeLog entries.  See this page for more details:

http://webkit.org/coding/contributing.html

Also note that it may have bit-rotted since the rename patch landed (and due to
other renames in the WebKit source tree).  

Overall the style and formatting of the code in the patch looks good.  You
might consider adding your own copyright statement to the modified files (or at
least the brand new file, even though it's based on an existing file).

Please update the patch and resubmit!


More information about the webkit-reviews mailing list