[webkit-reviews] review denied: [Bug 14845] Frame's noResize attribute can not be set by JavaScript : [Attachment 18494] First attempt (no test cases!)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 17 10:41:46 PST 2008


Dave Hyatt <hyatt at apple.com> has denied 's request for review:
Bug 14845: Frame's noResize attribute can not be set by JavaScript
http://bugs.webkit.org/show_bug.cgi?id=14845

Attachment 18494: First attempt (no test cases!)
http://bugs.webkit.org/attachment.cgi?id=18494&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I don't think setting margin width or height on the view has any effect after
it has been created, but I could be wrong.

The scrolling code is wrong.  You're getting the page(), which is the top-level
frame only.  So you're not really changing the scrollbar state on subframes.


More information about the webkit-reviews mailing list