[webkit-reviews] review requested: [Bug 16902] fast/encoding/mailto-always-utf-8.html fails when run after fast/dom/Window/window-property-shadowing.html : [Attachment 18504] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 17 10:48:19 PST 2008


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 16902: fast/encoding/mailto-always-utf-8.html fails when run after
fast/dom/Window/window-property-shadowing.html
http://bugs.webkit.org/show_bug.cgi?id=16902

Attachment 18504: proposed fix
http://bugs.webkit.org/attachment.cgi?id=18504&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
The showModalDialog exception is correct behavior - that's because DRT cannot
run modal, and says so via its UIDelegate.

There are many places in code where I could put the fix into, not sure if I
picked the best (or even correct) one.


More information about the webkit-reviews mailing list