[webkit-reviews] review requested: [Bug 16882] [GTK] ChromeClientGtk is incompete : [Attachment 18501] Implement stubs, no api changes, updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 17 08:18:00 PST 2008

Christian Dywan <christian at imendio.com> has asked  for review:
Bug 16882: [GTK] ChromeClientGtk is incompete

Attachment 18501: Implement stubs, no api changes, updated

------- Additional Comments from Christian Dywan <christian at imendio.com>
> > void ChromeClient::takeFocus(FocusDirection)
> > {
> >-	notImplemented();
> >+	unfocus();
> > }
> Shouldn't this be focus()? (I didn't check the other port implementations;
> might be worth doing that.

I did check other implementations. For instance Qt's implementations of
::unfocus() and ::takeFocus() contain the exact same code.

More information about the webkit-reviews mailing list