[webkit-reviews] review requested: [Bug 16219] [GTK] API: WebKitWebSettings is not usable : [Attachment 18500] Updated according to Mark's comments

[bugzilla-daemon at webkit.org]

Christian Dywan <christian at imendio.com> has asked  for review:
Bug 16219: [GTK] API: WebKitWebSettings is not usable
http://bugs.webkit.org/show_bug.cgi?id=16219

Attachment 18500: Updated according to Mark's comments
http://bugs.webkit.org/attachment.cgi?id=18500&action=edit

------- Additional Comments from Christian Dywan <christian at imendio.com>
(In reply to comment #10)
> (From update of attachment 18469 [edit])

> Using UTF-8 as the default value for the encoding has compatibility
> implications.  WebKit on Mac and Windows defaults to ISO-8859-1 (latin-1). 
> What is the reason for differing from Mac and Windows?
> 
> Using "Sans" as the default font family has compatibility implications.
> WebKit on Mac and Windows default to Times, which is a serif font family.
> What is the reason for using a sans-serif family here?
> 
> I haven't looked closely but I think several of the other defaults also
> differ from Mac and Windows.	It'd be worth looking over these and providing
> reasoning as to why they should differ for Gtk.

The reason is that WebKit is not meant to be used in a web browser exclusively
but as a general purpose view. It should be suitable for various use cases,
most of which won't ever display arbitrary websites. The conclusion is that the
defaults should be native values whereas the client still has the option to use
'compatible' values as desired.

> The *-placement of the gchar* declarations in webkit_web_view_update_settings

> is not correct.  We don't typically declare more than one variable per line,
> but in this case you're declaring 8 in one go so I'm not sure what the best
> approach is.

No idea how to improve that really. Declaring those in single lines would be
overkill.

> I think the description and possibly the name of "user-stylesheet" is
> unclear. The setting is for the URI of the user stylesheet, some clients
> may expect this to be the CSS data or similar.

After a little chat with Mark I am going for "user-stylesheet-uri".