[webkit-reviews] review granted: [Bug 17483] Implement Scrollbars on Windows (Cairo) : [Attachment 19452] Update revised based on Adam's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 29 12:42:32 PST 2008


Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at gmail.com>'s request for review:
Bug 17483: Implement Scrollbars on Windows (Cairo)
http://bugs.webkit.org/show_bug.cgi?id=17483

Attachment 19452: Update revised based on Adam's comments
http://bugs.webkit.org/attachment.cgi?id=19452&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
You're missing a ChangeLog for JavaScriptCore, but whomever lands this can make
one.

+static int cHorizontalWidth = 0;
+static int cHorizontalHeight = 0;
+static int cVerticalWidth = 0;
+static int cVerticalHeight = 0;
+static int cHorizontalButtonWidth = 0;
+static int cVerticalButtonHeight = 0;

statics are automatically initialized to 0 in C++, so this explicit
initialization isn't really necessary.

r=me


More information about the webkit-reviews mailing list