[webkit-reviews] review requested: [Bug 15119] Non-UTF-8 query parameters not handled properly when not generated by the form code : [Attachment 19443] Path with layout test

[bugzilla-daemon at webkit.org]

Marvin Decker <marv.decker at gmail.com> has asked  for review:
Bug 15119: Non-UTF-8 query parameters not handled properly when not generated
by the form code
http://bugs.webkit.org/show_bug.cgi?id=15119

Attachment 19443: Path with layout test
http://bugs.webkit.org/attachment.cgi?id=19443&action=edit

------- Additional Comments from Marvin Decker <marv.decker at gmail.com>
This adds an additional optional argument to the text encoding functions. This
is required since the query may contain "?" and ";" that should not be escaped,
yet the ones in the added entities should.

The form code does not need this flag. It builds the string up using unescaped
entities. When doing a post they shouldn't be escaped. When doing a get with
the parameters in the URL, all "&", ";" and "#" will be percent-escaped (since
they shouldn't interfere with the regular parsing of the URL).