[webkit-reviews] review requested: [Bug 17483] Implement Scrollbars on Windows (Cairo) : [Attachment 19440] Update based on aroben's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 28 17:52:58 PST 2008


Brent Fulgham <bfulgham at gmail.com> has asked  for review:
Bug 17483: Implement Scrollbars on Windows (Cairo)
http://bugs.webkit.org/show_bug.cgi?id=17483

Attachment 19440: Update based on aroben's comments
http://bugs.webkit.org/attachment.cgi?id=19440&action=edit

------- Additional Comments from Brent Fulgham <bfulgham at gmail.com>
* Switch wtf/Platform.h logic to use #if PLATFORM(WIN) && !PLATFORM(CG)
* Switch win/PlatformScrollbar.h logic to use #if PLATFORM(WIN) &&
!USE(SAFARI_THEME)
* Clean up comment type (actually, delete comment)
* Correct formatting
* Change scrollbar to get dimensions from GetSystemMetrics calls.  Use only
system metrics (not Safari-set 'controlSize') for scrollbar dimensions.
* Make theme handle a static entry in the implementation, since it's always the
same thing.  No longer release this handle as it is always needed during a run
of the browser.


More information about the webkit-reviews mailing list