[webkit-reviews] review granted: [Bug 17390] eliminate DeprecatedString : [Attachment 19159] Move all uses of toInt (and friends) to String

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 17390: eliminate DeprecatedString
http://bugs.webkit.org/show_bug.cgi?id=17390

Attachment 19159: Move all uses of toInt (and friends) to String
http://bugs.webkit.org/attachment.cgi?id=19159&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I think that having functions to do arbitrary base is overkill, since we rarely
need anything except base 10.

 803	 CString latin1String = Latin1Encoding().encode(data, length);
 804	 double val = kjs_strtod(latin1String.data(), &end);

I don't think the above is efficient enough. There's no reason this has to
allocate memory. We should convert to narrow characters in a fixed-size stack
buffer.

r=me