[webkit-reviews] review granted: [Bug 8749] XBM rendered incorrectly as black on white : [Attachment 19158] xbm image creation patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 16 19:08:31 PST 2008
Darin Adler <darin at apple.com> has granted Michael Knaup
<michael.knaup at mac.com>'s request for review:
Bug 8749: XBM rendered incorrectly as black on white
http://bugs.webkit.org/show_bug.cgi?id=8749
Attachment 19158: xbm image creation patch
http://bugs.webkit.org/attachment.cgi?id=19158&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
Two remaining problems:
1) A tab character in the change log.
2) This needs a regression test. I think we could do one with <canvas>.
I'm tempted to say r=me as-is, but (2) is a serious issue. I'll do review+ for
now, but please look into creating a regression test.
More information about the webkit-reviews
mailing list