[webkit-reviews] review denied: [Bug 16693] Acid3 expects WebKit to raise exceptions for invalid qualified names : [Attachment 19020] first attempt

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 16693: Acid3 expects WebKit to raise exceptions for invalid qualified names
http://bugs.webkit.org/show_bug.cgi?id=16693

Attachment 19020: first attempt
http://bugs.webkit.org/attachment.cgi?id=19020&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks like you have tabs in Document.cpp

Document:: functions don't need to use Document:: to reference static methods
in the same class.

Since you're changing method behavior in Element, you will need to add tests
for the changed behavior.  (Similar to what was added by bug 16833.)  One
probably which will probably stop this bug as well is that createElement calls
createElementNS (caused the regression that caused bug 16833 to get rolled
out).  Likewise setAttribute might be calling setAtributeNS.  That means that
this patch would not only need to test createElementNS and setAttributeNS, but
also createElement and setAttribute (it's the lack of testing of those two
which is currently blocking bug 16833 from completion).

r- w/o more test cases to prove this is correct.