[webkit-reviews] review requested: [Bug 16693] Acid3 expects WebKit to raise exceptions for invalid qualified names : [Attachment 19020] first attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 9 12:01:01 PST 2008


Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 16693: Acid3 expects WebKit to raise exceptions for invalid qualified names
http://bugs.webkit.org/show_bug.cgi?id=16693

Attachment 19020: first attempt
http://bugs.webkit.org/attachment.cgi?id=19020&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This patch incorporates and passes Erics testcase as well as the acid3 test.
Note that in most cases the check could be done inside parseQualifiedName too,
though createAttributeNS is a bit different here. To pass the tests this
suffices though, and there are no regressions in the current layout tests.
Cheers,

Rob.


More information about the webkit-reviews mailing list