[webkit-reviews] review denied: [Bug 17178] [curl] when using winsock, downloadTimerCallback bails : [Attachment 18919] On Win, don't call select unless we have a valid file descriptor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 20:09:09 PST 2008


Mark Rowe (bdash) <mrowe at apple.com> has denied Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 17178: [curl] when using winsock, downloadTimerCallback bails
http://bugs.webkit.org/show_bug.cgi?id=17178

Attachment 18919: On Win, don't call select unless we have a valid file
descriptor
http://bugs.webkit.org/attachment.cgi?id=18919&action=edit

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
That doesn't look right as it makes it possible for rc to be tested before
being initialized.  Why does it make sense to call select on non-Windows
platforms when there are no file descriptors?


More information about the webkit-reviews mailing list