[webkit-reviews] review requested: [Bug 16989] Add send() flag checks in XmlHttpRequest : [Attachment 18924] Updated patch with all the required testcases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 20:25:34 PST 2008


Julien Chaffraix <julien.chaffraix at gmail.com> has asked  for review:
Bug 16989: Add send() flag checks in XmlHttpRequest
http://bugs.webkit.org/show_bug.cgi?id=16989

Attachment 18924: Updated patch with all the required testcases
http://bugs.webkit.org/attachment.cgi?id=18924&action=edit

------- Additional Comments from Julien Chaffraix <julien.chaffraix at gmail.com>
> You say that this cannot be covered by test cases. If not, then what is the
> check for? Why is this change needed? Why can't we test it? We can easily
> construct a load that won't complete with our test HTTP server, I believe.

You are right, I was able to produce the missing test cases. I was not looking
in the right direction, thanks for pointing me to it.

> If we can't find a good name, I suggest internalAbort().

I have picked internalAbort() as other names do not fit or could be misleading
(we already have cancelRequests for example).

There was a big misinterpretation of the specification in the previous
iterations which is corrected in that patch (abort was not doing step 3 & 4
correctly).

I have been able to produce all the required test cases (I hope) and trying
them on the other browser does provide more information about the current
implementation :

- Opera does not have the send() flag checks in setRequestHeader and open
- Firefox does have the 2 checks

I could not check IE for the send() flag checks but I should be able to test
tomorrow. I will update the results here as soon as I can.


More information about the webkit-reviews mailing list