[webkit-reviews] review denied: [Bug 23027] Switch to more portable PlatformGraphicsContext types in WebKit.dll API : [Attachment 26307] Change CG types to PlatformGraphicsContext

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Brent Fulgham <bfulgham at gmail.com>'s
request for review:
Bug 23027: Switch to more portable PlatformGraphicsContext types in WebKit.dll
API
https://bugs.webkit.org/show_bug.cgi?id=23027

Attachment 26307: Change CG types to PlatformGraphicsContext
https://bugs.webkit.org/attachment.cgi?id=26307&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I think there's a misunderstanding here. The whole point of this API is that
it's something you can use without using WebCore-specific types. If you can use
those types, then you can use the WebCore functions directly.

Also, this API is used by Safari, so changing it will break compatibility of
nightly builds with the existing Safari.

I think the whole concept here is flawed. If we change this API we need a way
to keep existing clients compatible. And the use you're putting this API to
could probably be satisfied another way -- if the client has access to
WebCore's platform directory and those headers it can use it directly and
doesn't need this WebKitGraphics.h wrapper.