[webkit-reviews] review granted: [Bug 23022] Fix multiple issues with appcache online whitelist handling : [Attachment 26288] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 30 10:34:54 PST 2008


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 23022: Fix multiple issues with appcache online whitelist handling
https://bugs.webkit.org/show_bug.cgi?id=23022

Attachment 26288: proposed patch
https://bugs.webkit.org/attachment.cgi?id=26288&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    unsigned whitelistSize = m_onlineWhitelist.size();
> +    for (unsigned i = 0; i < whitelistSize; ++i) {

We normally use size_t to iterate vectors.

> +	   unsigned whitelistSize = onlineWhitelist.size();
> +	   for (unsigned i = 0; i < whitelistSize; ++i) {

Ditto.

For scaling, with large whitelists, it seems we might want to come up with a
hash function so we can use a hashed set rather than a vector.

> +# This should work normally.
> +counter.php?uncached
> \ No newline at end of file

Can we add a newline?

r=me


More information about the webkit-reviews mailing list