[webkit-reviews] review requested: [Bug 22929] Memory Regression from r39309 : [Attachment 26216] patch v2

[bugzilla-daemon at webkit.org]

Peter Kasting <pkasting at google.com> has asked Dave Hyatt <hyatt at apple.com> for
review:
Bug 22929: Memory Regression from r39309
https://bugs.webkit.org/show_bug.cgi?id=22929

Attachment 26216: patch v2
https://bugs.webkit.org/attachment.cgi?id=26216&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
That's depressing.

OK, this patch goes one small step further by reverting the CG ImageSource to
its former behavior of destroying the decoder after every large frame.	This
should fix the memory issues (please verify).

I'm not totally sure why this is necessary.  On the images I looked at it
looked as if the CG decoders were dropping frames that no one referenced (in
fact, so aggressively that they continued to redecode frames unnecessarily). 
But I don't have the CG source code so I can't look into this or implement a
"drop unnecessary frames" call like the other platforms now have, which is IMO
the correct way to address this issue.