[webkit-reviews] review cancelled: [Bug 22929] Memory Regression from r39309 : [Attachment 26148] patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 22 15:45:59 PST 2008

Peter Kasting <pkasting at google.com> has cancelled Peter Kasting
<pkasting at google.com>'s request for review:
Bug 22929: Memory Regression from r39309

Attachment 26148: patch v1

------- Additional Comments from Peter Kasting <pkasting at google.com>
That's depressing.

OK, this patch goes one small step further by reverting the CG ImageSource to
its former behavior of destroying the decoder after every large frame.	This
should fix the memory issues (please verify).

I'm not totally sure why this is necessary.  On the images I looked at it
looked as if the CG decoders were dropping frames that no one referenced (in
fact, so aggressively that they continued to redecode frames unnecessarily). 
But I don't have the CG source code so I can't look into this or implement a
"drop unnecessary frames" call like the other platforms now have, which is IMO
the correct way to address this issue.

More information about the webkit-reviews mailing list