[webkit-reviews] review requested: [Bug 22870] Animations and Transitions started in the same recalcStyle() cycle should have identical start times : [Attachment 26161] Replacement patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 19 14:51:20 PST 2008


Chris Marrin <cmarrin at apple.com> has asked Dave Hyatt <hyatt at apple.com> for
review:
Bug 22870: Animations and Transitions started in the same recalcStyle() cycle
should have identical start times
https://bugs.webkit.org/show_bug.cgi?id=22870

Attachment 26161: Replacement patch
https://bugs.webkit.org/attachment.cgi?id=26161&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
This fixes the issues identified and does the implementation a bit differently.
Rather than maintaining a time value in Document, it is now in
AnimationController. Document now makes begin/end calls to AnimationController
at the start and end of recalcStyle. Right now, the time value is reset in the
begin call and the end call does nothing. But it's there to keep things
symmetrical. And I will be needing the end call in the future for some of the
sync logic yet to do.


More information about the webkit-reviews mailing list