[webkit-reviews] review requested: [Bug 22936] Uninitialized memory read error in SimpleFontData::unitsPerEm() is reported by Purify : [Attachment 26160] Initialize m_unitsPerEm in SimpleFontData constructor v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 19 14:40:46 PST 2008


Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked  for review:
Bug 22936: Uninitialized memory read error in SimpleFontData::unitsPerEm() is
reported by Purify
https://bugs.webkit.org/show_bug.cgi?id=22936

Attachment 26160: Initialize m_unitsPerEm in SimpleFontData constructor v2
https://bugs.webkit.org/attachment.cgi?id=26160&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Darin, thanks again for making me look. I updated the patch to use the value,
provided by SVGFontFaceElement::unitsPerEm(), which is what would be used if
the font did not have the units_per_em attribute.


More information about the webkit-reviews mailing list