[webkit-reviews] review granted: [Bug 22793] Clean up FloatPoint3D : [Attachment 25922] Patch, changelog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 10 11:56:12 PST 2008


Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 22793: Clean up FloatPoint3D
https://bugs.webkit.org/show_bug.cgi?id=22793

Attachment 25922: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=25922&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +FloatPoint3D::FloatPoint3D(const FloatPoint& p)
> +    : m_x(p.x())
> +    , m_y(p.y())
> +    , m_z(0.f)
This should be m_z(0.0f) or just 0.

>  
> +#include "FloatPoint.h"

Can this simply be forward declared?

Otherwise, r=me.


More information about the webkit-reviews mailing list