[webkit-reviews] review requested: [Bug 22795] favicons should be saved to webarchives : [Attachment 25925] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 10 13:55:03 PST 2008
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked for review:
Bug 22795: favicons should be saved to webarchives
https://bugs.webkit.org/show_bug.cgi?id=22795
Attachment 25925: Patch v1
https://bugs.webkit.org/attachment.cgi?id=25925&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Proposed patch.
A couple of notes:
- Should I expose a method in WebIconDatabasePrivate.h to disable the icon
database instead of using a WebIconDatabaseInternal method? Or should I add
_applicationWillTerminate: to WebIconDatabaseInternal.h and make the header
Private so it is copied to PrivateHeaders?
- Similarly for the Windows LayoutTestController::setIconDatabaseEnabled(bool)
method, should I expose a WebIconDatabase::close() method instead of calling
shutDownWebKit()?
- I have not tried to compile the Windows code yet.
More information about the webkit-reviews
mailing list