[webkit-reviews] review granted: [Bug 22719] Implement Navigator object in Workers : [Attachment 25888] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 22719: Implement Navigator object in Workers
https://bugs.webkit.org/show_bug.cgi?id=22719

Attachment 25888: proposed patch
https://bugs.webkit.org/attachment.cgi?id=25888&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +JSValue* jsWorkerContextNavigator(JSC::ExecState* exec, const Identifier&,
const PropertySlot& slot)
> +{
> +    WorkerContext* imp =
static_cast<WorkerContext*>(static_cast<JSWorkerContext*>(asObject(slot.slotBas
e()))->impl());
> +    return toJS(exec, imp->navigator());
> +}

It's always irritating when we have to add a new DOM binding written by hand. I
trust there's a good reason, and I will settle for just complaining about it
rather than asking you to do something.

> +2008-12-09  Alexey Proskuryakov  <ap at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=22719
> +	   Implement Navigator object in Workers
> +
> +	   * fast/workers/worker-navigator-expected.txt: Added.
> +	   * fast/workers/worker-navigator.html: Added.
> +
> +2008-12-09  Alexey Proskuryakov  <ap at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   <rdar://problem/5959165> Crash in a number of iExploder tests in
WebCore::CachedImage::notifyObservers
> +
> +	   Add a test for a crash that is no longer reproducible.
> +
> +	   * fast/css/mask-missing-image-crash-expected.txt: Added.
> +	   * fast/css/mask-missing-image-crash.html: Added.
> +

Change log entry here from the other bug fix.

r=me