[webkit-reviews] review granted: [Bug 22757] break out text caret paint as enabled feature : [Attachment 25887] patch to allow disabling text caret

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Cary Clark <caryclark at google.com>'s
request for review:
Bug 22757: break out text caret paint as enabled feature
https://bugs.webkit.org/show_bug.cgi?id=22757

Attachment 25887: patch to allow disabling text caret
https://bugs.webkit.org/attachment.cgi?id=25887&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> Index: JavaScriptCore/ChangeLog
> ===================================================================
> --- JavaScriptCore/ChangeLog	(revision 39135)
> +++ JavaScriptCore/ChangeLog	(working copy)
> @@ -1,3 +1,13 @@
> +2008-12-09  Cary Clark  <caryclark at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	Add ENABLE_TEXT_CARET to permit the ANDROID platform
> +	to invalidate and draw the caret in a separate thread.
> +
> +	   * wtf/Platform.h:
> +	Default ENABLE_TEXT_CARET to 1.

ChangeLog has tabs in it. This makes it harder to land the patch, because the
committer has to change the tabs to spaces. Please don't use tabs in WebKit
changes.

Patch otherwise looks fine. r=me