[webkit-reviews] review denied: [Bug 20932] Notable leaks in QtWebkit - from Qt library : [Attachment 25012] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 8 12:44:21 PST 2008

Eric Seidel <eric at webkit.org> has denied Kelemen Balázs
<Kelemen.Balazs.3 at stud.u-szeged.hu>'s request for review:
Bug 20932: Notable leaks in QtWebkit - from Qt library

Attachment 25012: proposed patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm confused.  You move the location of * (to match WebKit style I assume?) yet
you don't clean up all the other style violations in this file (and add some of
your own with this patch -- like { } around single line ifs).  I'm not sure
what style the QtLauncher code is supposed to be in, but I assume WebKit style.
 I didn't actually look at the substance of the patch.

More information about the webkit-reviews mailing list