[webkit-reviews] review granted: [Bug 22612] Add test to verify type enforcement in DOM setters : [Attachment 25695] New test + result

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 4 09:16:23 PST 2008


Darin Adler <darin at apple.com> has granted Pam Greene <pam at chromium.org>'s
request for review:
Bug 22612: Add test to verify type enforcement in DOM setters
https://bugs.webkit.org/show_bug.cgi?id=22612

Attachment 25695: New test + result
https://bugs.webkit.org/attachment.cgi?id=25695&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
For a test like this, the preferred form is to have the entire test in a .js
file and let the make-js-test-wrappers test create a boilerplate wrapper.

It's a little strange to have this test only these two specific setters. It
would be way better to have something that made an attempt to be exhaustive.

r=me


More information about the webkit-reviews mailing list