[webkit-reviews] review granted: [Bug 20953] Rework the Font handling in QtWebKit : [Attachment 23592] Move the "fast" WebCore Font path to a separate file

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 20953: Rework the Font handling in QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=20953

Attachment 23592: Move the "fast" WebCore Font path to a separate file
https://bugs.webkit.org/attachment.cgi?id=23592&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Moving to a separate file seems fine.

> +/**

We don't use that double-star format.

> + * This file is part of the html renderer for KDE.

You can leave this out of the new file.

> + * Copyright (C) 1999 Lars Knoll (knoll at kde.org)
> + *		(C) 1999 Antti Koivisto (koivisto at kde.org)
> + *		(C) 2000 Dirk Mueller (mueller at kde.org)
> + * Copyright (C) 2003, 2006 Apple Computer, Inc.
> + * Copyright (C) 2008 Holger Hans Peter Freyther

None of the code you're moving is covered by the older copyrights (older than
2003); it's all new stuff. So you can omit those older copyright notices from
this new file.
> +    return data;
> +}
> +
> +
> +
> +}

We just use one blank line in places like this, not 3.

r=me on moving this code