[webkit-reviews] review granted: [Bug 22379] Make CSSOM use less memory : [Attachment 25721] Store CSSSelectors to an array instead of a linked list

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 22379: Make CSSOM use less memory
https://bugs.webkit.org/show_bug.cgi?id=22379

Attachment 25721: Store CSSSelectors to an array instead of a linked list
https://bugs.webkit.org/attachment.cgi?id=25721&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> Index: WebCore/css/CSSSelectorList.cpp
> ===================================================================
> --- WebCore/css/CSSSelectorList.cpp	(revision 0)
> +++ WebCore/css/CSSSelectorList.cpp	(revision 0)
> @@ -0,0 +1,55 @@
> +#include "config.h"
> +
> +#include "CSSSelectorList.h"

This needs a license header. Also, we don't usually put spaces between these
two includes.

> Index: WebCore/css/CSSSelectorList.h
> ===================================================================
> --- WebCore/css/CSSSelectorList.h	(revision 0)
> +++ WebCore/css/CSSSelectorList.h	(revision 0)
> @@ -0,0 +1,31 @@
> +#ifndef CSSSelectorList_h
> +#define CSSSelectorList_h

This needs a license header.

It's a little annoying that this class is called "List" when that so often
means linked list, but I think that's the best name.

r=me