[webkit-reviews] review denied: [Bug 22619] XMLHttpRequest needs to use scriptExecutionContext() instead of document() where possible. : [Attachment 25717] Removed the change to reportUnsafeUsage.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 3 13:34:10 PST 2008


Alexey Proskuryakov <ap at webkit.org> has denied David Levin
<levin at chromium.org>'s request for review:
Bug 22619: XMLHttpRequest needs to use scriptExecutionContext() instead of
document() where possible.
https://bugs.webkit.org/show_bug.cgi?id=22619

Attachment 25717: Removed the change to reportUnsafeUsage.
https://bugs.webkit.org/attachment.cgi?id=25717&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Code changes all look right, but the ChangeLog may be a little too expressive
:). I think that the full history should go to bug comments, not into
ChangeLog. Also, the description of responseXML changes is a bit misleading -
the purpose is not to zero out m_responseXML, but to return null without
executing code that is not thread safe.

I'm going to say r- for now, because ChangeLog takes the biggest part of this
patch, and it needs to be significantly modified.


More information about the webkit-reviews mailing list