[webkit-reviews] review granted: [Bug 22606] Can <th> serves as the AXTitleUIElement for <td>? : [Attachment 25687] patch to make <th> behave as title ui element
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 2 15:38:24 PST 2008
Beth Dakin <bdakin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 22606: Can <th> serves as the AXTitleUIElement for <td>?
https://bugs.webkit.org/show_bug.cgi?id=22606
Attachment 25687: patch to make <th> behave as title ui element
https://bugs.webkit.org/attachment.cgi?id=25687&action=review
------- Additional Comments from Beth Dakin <bdakin at apple.com>
This is a nitpick, but we generally sentence-case our comments. I would
appreciate it if you would do that in the comments below. (Meaning, capitalize
the first letter of the first work in each sentence.
> + // try to find if the first cell in this row is a <th>. if it is,
> + // then it can act as the title ui element. (this is only in the
> + // case when the table is not appearing as an AXTable)
> + if (!m_renderer || isTableCell())
> + return 0;
And here:
> + // if this cell is in the first column, there is no need to continue
> + int col = renderCell->col();
More information about the webkit-reviews
mailing list