[webkit-reviews] review granted: [Bug 22564] Make HTML elements' constructors take a QualifiedName : [Attachment 25685] 2nd part: Update the remaining constructors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 2 15:28:19 PST 2008


Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at pleyo.com>'s request for review:
Bug 22564: Make HTML elements' constructors take a QualifiedName
https://bugs.webkit.org/show_bug.cgi?id=22564

Attachment 25685: 2nd part: Update the remaining constructors
https://bugs.webkit.org/attachment.cgi?id=25685&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Might as well make this one line:
 static PassRefPtr<HTMLElement> objectConstructor(const QualifiedName&,
Document* doc, HTMLFormElement*, bool createdByParser)
 {
-    RefPtr<HTMLObjectElement> object = new HTMLObjectElement(doc,
createdByParser);
+    RefPtr<HTMLObjectElement> object = new HTMLObjectElement(objectTag, doc,
createdByParser);
     return object.release();
 }

otherwise looks great!


More information about the webkit-reviews mailing list