[webkit-reviews] review granted: [Bug 22588] securityOrigin() should move from Document and WorkerContext into ScriptExecutionContext : [Attachment 25668] patch for bug.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 2 00:20:16 PST 2008


Alexey Proskuryakov <ap at webkit.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 22588: securityOrigin() should move from Document and WorkerContext into
ScriptExecutionContext
https://bugs.webkit.org/show_bug.cgi?id=22588

Attachment 25668: patch for bug.
https://bugs.webkit.org/attachment.cgi?id=25668&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

It is quite sad that you have to hack around the difference between
ScriptExecutionContext::setSecurityOrigin and Document::setSecurityOrigin. I
think that the initDNSPrefetch() call in setSecurityOrigin() is misplaced -
there are lots of things that depend on protocol in loader, but we don't
eagerly initialize them all in setSecurityOrigin(), or track in Document at
all.


More information about the webkit-reviews mailing list