[webkit-reviews] review denied: [Bug 22497] Parse turns for <angle> units : [Attachment 25667] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 1 22:57:55 PST 2008

mitz at webkit.org has denied Dean Jackson <dino at apple.com>'s request for review:
Bug 22497: Parse turns for <angle> units

Attachment 25667: updated patch

------- Additional Comments from mitz at webkit.org
The values in the .idl come from
<http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-CSSPrimitiveValue> and I
don't think they can be changed. Since the turn unit is not specified (yet?), I
think it should be left out of the IDL completely and assigned a UnitType value
that does not clash with the IDL-specified ones. It seems like the
100-and-higher range has been used for such "units".

Sorry about not thinking about all that before making my previous comment :(

More information about the webkit-reviews mailing list