[webkit-reviews] review granted: [Bug 20013] Windows AX heuristics are poor : [Attachment 23005] Patch to expose list elements and populate role attribute for them correctly.

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has granted Sankar Aditya Tanguturi
<sankaraditya+bugzilla at gmail.com>'s request for review:
Bug 20013: Windows AX heuristics are poor
https://bugs.webkit.org/show_bug.cgi?id=20013

Attachment 23005: Patch to expose list elements and populate role attribute for
them correctly.
https://bugs.webkit.org/attachment.cgi?id=23005&action=edit

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
Sankar, great! Really happy to see this.

+++ LayoutTests/accessibility/listelements-detection-expected.txt

Because the role text is going to be different between platforms, I suggest you
move the listelements-detection-expected.txt result to
LayoutTests/platform/win/accessibility/. We can then put the mac-specific
results in platform/mac/accessibility.

Also, accessibility tests are currently disabled on Windows. You should edit
the LayoutTests/platform/win/Skipped file, remove the lines:

# Still need to implement AccessibilityController for DumpRenderTree on Windows

accessibility

and replace them with, for example:

# These tests don't run under Windows or have mac-specific results.
https://bugs.webkit.org/show_bug.cgi?id=20497
accessibility/aria-describedby-on-input.html
accessibility/aria-labelledby-on-input.html
accessibility/aria-range-value.html
accessibility/aria-range.html
accessibility/aria-roles.html
accessibility/aria-slider.html
accessibility/aria-spinbutton.html
accessibility/bounds-for-range.html
accessibility/document-attributes.html
accessibility/image-map1.html
accessibility/image-map2.html
accessibility/internal-link-anchors.html
accessibility/internal-link-anchors2.html
accessibility/radio-button-checkbox-size.html
accessibility/radio-button-group-members.html
accessibility/table-attributes.html
accessibility/table-cell-spans.html
accessibility/table-cells.html
accessibility/table-detection.html
accessibility/table-sections.html
accessibility/table-with-rules.html
accessibility/textarea-insertion-point-line-number.html
accessibility/textarea-line-for-index.html

r=me with this change, and thanks!