[webkit-reviews] review granted: [Bug 20516] REGRESSION (r35918): Safari crashes when trying to use "Filter messages like these" : [Attachment 23008] Proposed patch and layout test.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 26 16:35:34 PDT 2008


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has granted 's request for
review:
Bug 20516: REGRESSION (r35918): Safari crashes when trying to use "Filter
messages like these"
https://bugs.webkit.org/show_bug.cgi?id=20516

Attachment 23008: Proposed patch and layout test.
https://bugs.webkit.org/attachment.cgi?id=23008&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
You should probably mention the Bugzilla bug in the ChangeLog as well as the
Radar bug. Also, your test file has no newline at the end, and you did not
include the expected test results in the diff.

Other than that, r=me.


More information about the webkit-reviews mailing list