[webkit-reviews] review denied: [Bug 20380] [GTK][AUTOTOOLS] Include aconfig.h from config.h : [Attachment 22789] Include aconfig.h if available

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 25 21:07:15 PDT 2008

Eric Seidel <eric at webkit.org> has denied Marco Barisione
<marco.barisione at collabora.co.uk>'s request for review:
Bug 20380: [GTK][AUTOTOOLS] Include aconfig.h from config.h

Attachment 22789: Include aconfig.h if available

------- Additional Comments from Eric Seidel <eric at webkit.org>
JavaScriptGlue is a mac-only project, I don't see why it would need any changes
to config.h

Why is aconfig.h needed?  Could it have a better name too?  Like
autoconf_config.h or similar?

The Mac and Windows ports pass various ENABLE_ defines via compiler flags.  I
would assume that the Automake system would do the same, but I guess you're
suggesting that the automake way is to pass these ENABLE_* defines as part of

Marking r- and waiting for further clarification.

More information about the webkit-reviews mailing list