[webkit-reviews] review denied: [Bug 19578] [CURL] problem in parseDataUrl : [Attachment 22956] fix ChangeLog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 25 21:01:27 PDT 2008
Eric Seidel <eric at webkit.org> has denied Mario Bensi <mbensi at pleyo.com>'s
request for review:
Bug 19578: [CURL] problem in parseDataUrl
https://bugs.webkit.org/show_bug.cgi?id=19578
Attachment 22956: fix ChangeLog
https://bugs.webkit.org/attachment.cgi?id=22956&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
I know Darin r+'d the old one, but I think this patch still could use one more
round.
The changelog contains tabs. I still see no reason why the USE_GLIB_BASE64
path needs to exist. I suggest we remove it. r- for the tabs in the changelog
and lack of explanation as to why we should keep the USE_GLIB_BASE64 path.
Otherwise the patch looks fine. Thanks again! I look forward to seeing the
final patch.
More information about the webkit-reviews
mailing list