[webkit-reviews] review granted: [Bug 19578] [CURL] problem in parseDataUrl : [Attachment 22937] keep vector ( real patch )

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Mario Bensi <mbensi at pleyo.com>'s
request for review:
Bug 19578: [CURL] problem in parseDataUrl
https://bugs.webkit.org/show_bug.cgi?id=19578

Attachment 22937: keep vector ( real patch )
https://bugs.webkit.org/attachment.cgi?id=22937&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	 fix the String conversion on base64 data in parseDataUrl

This is a kind of vague description of what's being changed. And it doesn't
contain a bugs.webkit.org URL; it should.

+	 WARNING: NO TEST CASES ADDED OR CHANGED

That should have been removed from the ChangeLog.

+	 * platform/network/curl/ResourceHandleManager.cpp:
+	 (WebCore::parseDataUrl):

It's better if the ChangeLog actually says what the change is.

The ifdefs in this function are kind of strange. Some of the code using outData
and out is inside #ifdefs and others are outside and unconditional. It would be
much better to be consistent.

But I'll say r=me, as-is