[webkit-reviews] review granted: [Bug 3591] Frames only use integers as its length : [Attachment 22939] Updated patch incorporating feedback

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brad Garcia <bgarcia at google.com>'s
request for review:
Bug 3591: Frames only use integers as its length
https://bugs.webkit.org/show_bug.cgi?id=3591

Attachment 22939: Updated patch incorporating feedback
https://bugs.webkit.org/attachment.cgi?id=22939&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks for taking this on. The patch looks good.

Some comments about things that are not new to your patch.

I think it's strange that this code is also used for HTMLAreaElement. Are these
changes all OK for that case too? I think the name of this function is
unfortunate since it's not suitable for general length parsing and has quirks
that are quite specific to the use parsing frame sizes.

The use of Unicode::isDigit seems wrong here. Do we really support non-ASCII
digits? I think it should be isASCIIDigit instead.

+	 /* IE Quirk: accept decimal fractions for percentages */

We normally use // comments (despite the IE quirk comment a few lines earlier).


r=me