[webkit-reviews] review denied: [Bug 19578] [CURL] problem in parseDataUrl : [Attachment 22771] fix the base64 problem ( fix coding style )

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Sam Weinig <sam at webkit.org>'s request
for review:
Bug 19578: [CURL] problem in parseDataUrl
https://bugs.webkit.org/show_bug.cgi?id=19578

Attachment 22771: fix the base64 problem ( fix coding style )
https://bugs.webkit.org/attachment.cgi?id=22771&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Please use a Vector<char> instead of using manual memory management.

Even OwnPtr would be better than manual use of fastFree.

Also, else should be on the same line as your }

In fact!  out is already a Vector<char>!! So you're just making a needless copy
here. :(

Please move the Vector<char> out declaration outside of the if block.  And
heck, just remove the USE_GLIB_BASE64 path, there is no reason to use
g_base64_decode even if it's available.  Just remove the g_base64_decode
codepath entirely.